Differential D15311

Remove the unused TX_RECENT_CONSENSUS_CHANGE tx validation result
ClosedPublic
Actions

Authored by Fabien on Jan 29 2024, 10:21.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3ae66bb5cc47: Remove the unused TX_RECENT_CONSENSUS_CHANGE tx validation result

Summary

This has been introduced as a placeholder and never used for years. It makes also the misbehaving function for bad tx a bit cleaner as it's not obvious we would not ban a peer for a consensus failure in a hypothetical future.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 29 2024, 10:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2024, 10:21

Fabien requested review of this revision.Jan 29 2024, 10:21

Harbormaster completed remote builds in B26710: Diff 44673.Jan 29 2024, 11:01

PiRK accepted this revision.Jan 29 2024, 11:37

This revision is now accepted and ready to land.Jan 29 2024, 11:37

Closed by commit rABC3ae66bb5cc47: Remove the unused TX_RECENT_CONSENSUS_CHANGE tx validation result (authored by Fabien). · Explain WhyJan 29 2024, 13:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3ae66bb5cc47: Remove the unused TX_RECENT_CONSENSUS_CHANGE tx validation result.

Revision Contents
Changeset List

Path

Size

src/

consensus/

validation.h

5 lines

net_processing.cpp

1 line

Diff 44678

View Options

src/consensus/validation.h