Page MenuHomePhabricator

Make fs.h C++20 compliant and improve fs::PathToString documentation
ClosedPublic

Authored by PiRK on Jan 29 2024, 17:17.

Details

Summary

Without the changes, the file will fail to compile under C++20 because
char8_t can not be converted to char implicitly.

This is a backport of core#23522 and core#24169
https://github.com/bitcoin/bitcoin/pull/24169/commits/fabb7c4ba629ecdea80a23674e2659d3d391565f
https://github.com/bitcoin/bitcoin/pull/23522/commits/9b575f1c734c052b695ce921fb6412b22c18fdb4

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jan 29 2024, 17:17

Tail of the build log:

[362/544] Linking C executable src/secp256k1/internal-bench
[363/544] Linking CXX static library src/libcommon.a
[364/544] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[365/544] Linking CXX static library src/libscript.a
[366/544] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[367/544] Linking CXX static library src/libbitcoinconsensus.a
[368/544] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[369/544] Linking CXX shared library src/libbitcoinconsensus.so.0.28.8
[370/544] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[371/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[372/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[373/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[374/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[375/544] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[376/544] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[377/544] Linking CXX executable src/bitcoin-cli
[378/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[379/544] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[380/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[381/544] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[382/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[383/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[384/544] Linking CXX executable src/bitcoin-tx
[385/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[386/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[387/544] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[388/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[389/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[390/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[391/544] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[392/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[393/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[394/544] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[395/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[396/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[397/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[398/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[399/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[400/544] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[401/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[402/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[403/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[404/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[405/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[406/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[407/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[408/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[409/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[410/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[411/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[412/544] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[413/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[414/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[415/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[416/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[417/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[418/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[419/544] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[365/544] Linking C executable src/secp256k1/internal-bench
[366/544] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[367/544] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[368/544] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[369/544] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[370/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[371/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[372/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[373/544] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[374/544] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[375/544] Linking CXX executable src/bitcoin-cli
[376/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[377/544] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[378/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[379/544] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[380/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[381/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[382/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[383/544] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[384/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[385/544] Linking CXX executable src/bitcoin-tx
[386/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[387/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[388/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[389/544] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[390/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[391/544] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[392/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[393/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[394/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[395/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[396/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[397/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[398/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[399/544] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[400/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[401/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[402/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[403/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[404/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[405/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[406/544] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[407/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[408/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[409/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[410/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[411/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[412/544] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[413/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[414/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[415/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[416/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[417/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[418/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[419/544] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Tail of the build log:

[362/544] Linking CXX static library src/libcommon.a
[363/544] Linking CXX static library src/libscript.a
[364/544] Linking CXX static library src/libbitcoinconsensus.a
[365/544] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[366/544] Linking CXX shared library src/libbitcoinconsensus.so.0.28.8
[367/544] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[368/544] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[369/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[370/544] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[371/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[372/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[373/544] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[374/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[375/544] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[376/544] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[377/544] Linking CXX executable src/bitcoin-cli
[378/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[379/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[380/544] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[381/544] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[382/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[383/544] Linking CXX executable src/bitcoin-tx
[384/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[385/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[386/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[387/544] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[388/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[389/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[390/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[391/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[392/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[393/544] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[394/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[395/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[396/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[397/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[398/544] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[399/544] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[400/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[401/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[402/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[403/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[404/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[405/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[406/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[407/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[408/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[409/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[410/544] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[411/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[412/544] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[413/544] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[414/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[415/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[416/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[417/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[418/544] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[419/544] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Tail of the build log:

[458/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/error.cpp.o
[459/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/timedata.cpp.o
[460/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/netbase.cpp.o
[461/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[462/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/asmap.cpp.o
[463/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[464/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/sock.cpp.o
[465/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[466/607] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[467/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[468/607] Linking C static library src/secp256k1/libsecp256k1.a
[469/607] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[470/607] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[471/607] Linking C executable src/secp256k1/recover-bench
[472/607] Linking C executable src/secp256k1/ecmult-bench
[473/607] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[474/607] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[475/607] Linking C executable src/secp256k1/verify-bench
[476/607] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[477/607] Linking C executable src/secp256k1/sign-bench
[478/607] Linking C executable src/secp256k1/internal-bench
[479/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[480/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[481/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/amount.cpp.o
[482/607] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[483/607] Linking CXX static library src/libbitcoinconsensus.a
[484/607] Linking CXX static library src/libscript.a
[485/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[486/607] Linking CXX static library src/libcommon.a
[487/607] Building CXX object src/CMakeFiles/bitcoinconsensus-shared.dir/script/bitcoinconsensus.cpp.o
[488/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[489/607] Linking CXX shared library src/libbitcoinconsensus.so.0.28.8
[490/607] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[491/607] Linking CXX executable src/bitcoin-cli
[492/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[493/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[494/607] Linking CXX static library src/zmq/libzmq.a
[495/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[496/607] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[497/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[498/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[499/607] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[500/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[501/607] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[502/607] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[503/607] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[504/607] Linking CXX executable src/bitcoin-tx
[505/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[506/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[507/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[508/607] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[509/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
[510/607] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[511/607] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[512/607] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[513/607] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
[514/607] Linking CXX static library src/libbitcoinkernel.a
[515/607] Linking CXX executable src/bitcoin-chainstate
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

rebase after fixing CMAKE_CXX_STANDARD

Tail of the build log:

[361/542] Linking C executable src/secp256k1/sign-bench
[362/542] Linking C executable src/secp256k1/ecmult-bench
[363/542] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[364/542] Linking C executable src/secp256k1/internal-bench
[365/542] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[366/542] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[367/542] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[368/542] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[369/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[370/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[371/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[372/542] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[373/542] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[374/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[375/542] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[376/542] Linking CXX executable src/bitcoin-cli
[377/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[378/542] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[379/542] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[380/542] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[381/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[382/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[383/542] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[384/542] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[385/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[386/542] Linking CXX executable src/bitcoin-tx
[387/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[388/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[389/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[390/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[391/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[392/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[393/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[394/542] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[395/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[396/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[397/542] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[398/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[399/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[400/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[401/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[402/542] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[403/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[404/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[405/542] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[406/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[407/542] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[408/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[409/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[410/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[411/542] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[412/542] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[413/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[414/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[415/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[416/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[417/542] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[418/542] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Fabien requested changes to this revision.Jan 30 2024, 08:33
Fabien added a subscriber: Fabien.

Needs rebase

This revision now requires changes to proceed.Jan 30 2024, 08:33
This revision is now accepted and ready to land.Jan 30 2024, 15:30