Adding a rss generator package and function to make rss feed for blog as requested
fyi the reason the generateRssFeed function is where it is, is because next was throwing errors when trying to use fs outside of a getStaticProps file
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC27d3cb2b7313: [e.cash] add rss feed for blog
preview the site and check out /rss.xml. Should see rss data
Can also use a rss reader like this one to test https://chromewebstore.google.com/detail/rss-feed-reader/pnjaodmkngahhkoihejjehlcdlnohgmp
Plug in localhost if youre running locally, or the bot url and see if the feed populates correctly
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-rss-feed
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26781 Build 53130: Build Diff Build 53129: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41435 for the next 60 minutes.
| web/e.cash/pages/blog.js | ||
|---|---|---|
| 122 ↗ | (On Diff #44695) | can we not get an image for each post? |
Comment Actions
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Comment Actions
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41856 for the next 60 minutes.
Comment Actions
yeah looks like theres not a straight forward image value for the feed item, but you can add it to enclosure like this...unsure how its supposed to render in a reader, or what the norm is. But testing now with the bot build
Comment Actions
Okay nice, looks to be working with this reader https://rssviewer.app/. Free version of feeder doesnt seem to load images
| web/e.cash/pages/blog.js | ||
|---|---|---|
| 128 ↗ | (On Diff #44741) | can we avoid the hardcoded url ? So we can move the backend easily |
| web/e.cash/pages/blog.js | ||
|---|---|---|
| 128 ↗ | (On Diff #44741) | Would be better, I actually have a task to do this as its currently hardcoded in some other places as well. Should I add to this diff or do it in another? |
| web/e.cash/pages/blog.js | ||
|---|---|---|
| 128 ↗ | (On Diff #44741) | as you are introducing this instance here in this diff -- simply do not introduce it in this diff. use a var instead of hardcoding it. in a later diff, it could make sense to use that same var to replace any other instances. |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41859 for the next 60 minutes.
Comment Actions
the whole enclosure thing instead of just a normal image tag is weird.
who wants this rss feed and what do they want it for?
Comment Actions
Aimal requested: 'Recently, Binance requested one, for now, we told them to sync content from our Twitter account but would be great to have one. They need it to easily sync our blog content on our new Binance Square account.'
Comment Actions
ok. we might have to come back later and match their format. but, this is better than what we have now.