Paths

Table of Contentst

Differential D15333

[Cashtab] Move app tests to appropriate dir level
ClosedPublic
Actions

Authored by bytesofman on Jan 30 2024, 21:22.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC467cd6233d3c: [Cashtab] Move app tests to appropriate dir level

Summary

App.js is at the top level of src/components. It's test should also be at the top level, at src/somponents/__tests__

It is instead at src/components/Common/__tests__. This is the result of an error when creating directories.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move-app-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26763
Build 53094: Build Diff	cashtab-tests
Build 53093: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 30 2024, 21:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2024, 21:22

version bump

Harbormaster completed remote builds in B26763: Diff 44746.Jan 30 2024, 21:39

Harbormaster completed remote builds in B26764: Diff 44747.Jan 30 2024, 21:42

bytesofman published this revision for review.Jan 30 2024, 22:14

emack accepted this revision.Jan 31 2024, 06:21

This revision is now accepted and ready to land.Jan 31 2024, 06:21

Closed by commit rABC467cd6233d3c: [Cashtab] Move app tests to appropriate dir level (authored by bytesofman). · Explain WhyJan 31 2024, 11:06

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC467cd6233d3c: [Cashtab] Move app tests to appropriate dir level.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Common/

__tests__/

App.test.js

		__tests__/
	Common/	__tests__/

App.test.js

86 lines

Diff 44746

View Options

cashtab/src/components/Common/tests/App.test.js

View Options

cashtab/src/components/tests/App.test.js

[Cashtab] Move app tests to appropriate dir levelClosedPublicActions