Add tests to confirm routing functionality of the main nav menu
Note: no version bump as this diff has no impact on the production app
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCf6bc5905da4a: [Cashtab] Add tests for routing
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| cashtab/src/components/Common/__tests__/App.test.js | ||
|---|---|---|
| 111 ↗ | (On Diff #44752) | |
| cashtab/src/components/Common/__tests__/App.test.js | ||
|---|---|---|
| 111 ↗ | (On Diff #44752) | imo this is overkill, we already establish that the containing element has height 0. we don't need to prove that we can't see child menu items. also fwiw, this would fail -- the menu elements are in the document. not.toBeInTheDocument() is for elements we expect not render, i.e. something is rendered conditionally on some state variable. These elements are hidden with css, so would need to test that property. |