[chronik-client] Setup scripts should have yield False on last steps
AbandonedPublic
Actions

Authored by bytesofman on Jan 30 2024, 22:51.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

yield False for the last step. This makes the setup to raise an error if this is unexpected and ensure both TS and python are in sync

Test Plan

Leave it to CI or check D14915 for local building and testing steps

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cc-yield-false-end

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26771
Build 53110: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 53109: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 30 2024, 22:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2024, 22:51

bytesofman published this revision for review.Jan 30 2024, 22:51

Harbormaster completed remote builds in B26771: Diff 44754.Jan 30 2024, 23:14

Not sure where this was lost in the process, but apparently it's on me

This revision is now accepted and ready to land.Jan 31 2024, 08:57

Not sure where this was lost in the process, but apparently it's on me

Indeed I used the iteration exception instead of the return value in my final design and forgot about it. Sorry for the noise, you can abandon the diff.

This revision now requires changes to proceed.Jan 31 2024, 09:47

bytesofman abandoned this revision.Jan 31 2024, 11:27