Paths

Table of Contentst

Differential D15346

guix: Remove librt usage from release binaries
ClosedPublic
Actions

Authored by PiRK on Jan 31 2024, 15:48.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1fe9d2ad2d79: guix: Remove librt usage from release binaries

Summary

contrib: remove librt from release deps

guix: backport glibc patch to prevent redundant librt link

This is a backport of core#28069
Depends on D15345

Test Plan

gitian builds
contrib/guix/guix-build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

update_guix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26801
Build 53170: Build Diff
Build 53169: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 31 2024, 15:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2024, 15:48

teamcity edited the summary of this revision. (Show Details)Jan 31 2024, 15:48

Harbormaster completed remote builds in B26800: Diff 44796.Jan 31 2024, 15:48

don't forget the patch

Harbormaster completed remote builds in B26801: Diff 44797.Jan 31 2024, 15:53

PiRK added inline comments.Jan 31 2024, 15:54

contrib/guix/manifest.scm
561	the blank line was accidentaly added by me in a previous backport while fixing a merge conflict
contrib/guix/patches/glibc-2.28-no-librt.patch
1	The patch should be identical for glibc 2.27 and 2.28 (see https://sourceware.org/git/?p=glibc.git;a=history;f=rt/clock-compat.c;h=f816973c05c29d5d3c731b2e83c4d25ade658cb2;hb=refs/heads/release/2.28/master)

@bot gitian-linux gitian-win gitian-osx

teamcity awarded a token.Jan 31 2024, 15:55

PiRK published this revision for review.Feb 1 2024, 07:11

Fabien accepted this revision.Feb 1 2024, 08:32

This revision is now accepted and ready to land.Feb 1 2024, 08:32

Closed by commit rABC1fe9d2ad2d79: guix: Remove librt usage from release binaries (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyFeb 1 2024, 08:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1fe9d2ad2d79: guix: Remove librt usage from release binaries.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

symbol-check.py

1 line

guix/

4 lines

patches/

glibc-2.28-no-librt.patch

53 lines

Diff 44797

contrib/devtools/symbol-check.py

Loading...

contrib/guix/manifest.scm

Loading...

contrib/guix/patches/glibc-2.28-no-librt.patch

Loading...