[electrum] fix get_merkle_root when Electrum ABC is not installed
ClosedPublic
Actions

Authored by PiRK on Feb 1 2024, 07:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC891ff94e7e1d: [electrum] fix get_merkle_root when Electrum ABC is not installed

Summary

The script cannot import electrumabc if it is not in the python PATH. We could install ElectrumABC as a package with pip install . in update-electrum-checkpoints.sh, but it is simpler to just hack sys.path to make sure the script always work with the latest version of the source code.

Test Plan

pip uninstall ElectrumABC
cd ./contrib/source-control-tools
./patch-recipes/update-electrum-checkpoints.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_electrum_checkpoints

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26826
Build 53220: Build Diff	electrum-tests
Build 53219: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 1 2024, 07:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2024, 07:45

PiRK requested review of this revision.Feb 1 2024, 07:45

Harbormaster completed remote builds in B26826: Diff 44834.Feb 1 2024, 07:47

PiRK retitled this revision from [electrum] make the get_merkle_root script work even if Electrum ABC is not installed to [electrum] fix get_merkle_root when Electrum ABC is not installed.Feb 1 2024, 07:53

Fabien accepted this revision.Feb 1 2024, 08:21

This revision is now accepted and ready to land.Feb 1 2024, 08:21

Closed by commit rABC891ff94e7e1d: [electrum] fix get_merkle_root when Electrum ABC is not installed (authored by PiRK). · Explain WhyFeb 1 2024, 08:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC891ff94e7e1d: [electrum] fix get_merkle_root when Electrum ABC is not installed.