Page MenuHomePhabricator
Differential D15358

[electrum] run isort on python scripts with no extension
ClosedPublic
Actions

Authored by PiRK on Feb 1 2024, 10:56.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC7b4a74447afe: [electrum] run isort on python scripts with no extension
Summary

Run the ISort linter on python code that was not linted because it was missing the .py extension. In a following commit, we will rename them so they will be linted automatically.
The main entry point for the application will not get a .py extension, so add it to include in .arclint.

Depends on D15357

Test Plan
arc lint -- electrum/electrum-abc

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 1 2024, 10:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2024, 10:56
PiRK requested review of this revision.Feb 1 2024, 10:56
Harbormaster completed remote builds in B26830: Diff 44842.Feb 1 2024, 10:58
PiRK added a child revision: D15359: [electrum] run flake8 on python scripts missing the .py extension.Feb 1 2024, 11:05
PiRK updated this revision to Diff 44857.Feb 1 2024, 14:07
PiRK retitled this revision from [electrum] run the isort linter on python scripts with no extension to [electrum] run isort on python scripts with no extension.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

don't add the sripts dir to .arclint, we will just rename the script to have the .py extension

Harbormaster completed remote builds in B26843: Diff 44857.Feb 1 2024, 14:09
bytesofman accepted this revision.Feb 1 2024, 17:30
This revision is now accepted and ready to land.Feb 1 2024, 17:30
Closed by commit rABC7b4a74447afe: [electrum] run isort on python scripts with no extension (authored by PiRK). · Explain WhyFeb 2 2024, 07:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7b4a74447afe: [electrum] run isort on python scripts with no extension.

Revision Contents
Changeset List

PathSize
5 lines
electrum/
2 lines
scripts/
2 lines
2 lines
2 lines

Diff 44896

View Options

.arclint

Loading...
View Options

electrum/electrum-abc

Loading...
View Options

electrum/scripts/block_headers

Loading...
View Options

electrum/scripts/get_history

Loading...
View Options

electrum/scripts/watch_address

Loading...