Page MenuHomePhabricator

[Cashtab] Update SendXec with direct calls to antd notifications
ClosedPublic

Authored by emack on Feb 1 2024, 12:25.

Details

Summary

This diff deprecates sendXecNotification and updates SendXec.js to call on the antd component directly.

Notification unit test already covered under SendXec.test.js' Clicking "Send" will send a valid tx with op_return_raw after entry of a valid address and bip21 query string with valid amount and op_return_raw params to Send To field test.

Test Plan
  • grep -r sendXecNotification src/ with no output
  • npm test
  • npm start
  • success notif: send a one to one XEC tx (no change to notification UI)
  • error notif: send a one to many XEC tx with an amount larger than balance

image.png (290×403 px, 17 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendXecNotifs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26866
Build 53299: Build Diffcashtab-tests
Build 53298: arc lint + arc unit

Event Timeline

emack requested review of this revision.Feb 1 2024, 12:25

error notif: send a one to many XEC tx with an amount larger than balance

unrelated but we should be catching this in validation

bytesofman requested changes to this revision.Feb 1 2024, 13:30
bytesofman added inline comments.
cashtab/src/components/Send/SendXec.js
418–421 ↗(On Diff #44846)
510–525 ↗(On Diff #44846)

don't define a var if we only use it one time

This revision now requires changes to proceed.Feb 1 2024, 13:30
emack marked 2 inline comments as done.

Updated var assignments

This revision is now accepted and ready to land.Feb 1 2024, 17:36