Page MenuHomePhabricator
Differential D15377

[Cashtab] Update configure.js with direct antd calls
AbandonedPublicDraft
Actions

Authored by emack on Feb 2 2024, 14:08.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This diff replaces all uses of Notification.js functions in Configure.js with direct calls to the antd notification component, which happens to all be related to the Contact List feature.

Also integration tests added for this component.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
configureNotifs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26980
Build 53526: Build Diffcashtab-tests
Build 53525: arc lint + arc unit

Event Timeline

emack created this revision.Feb 2 2024, 14:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2024, 14:08
Harbormaster completed remote builds in B26885: Diff 44915.Feb 2 2024, 14:22
emack updated this revision to Diff 44935.Feb 3 2024, 13:19

Added initial integration test, still need to mock localForage when a localForage mock can't be passed in as a function arg.

Harbormaster completed remote builds in B26900: Diff 44935.Feb 3 2024, 13:19
emack updated this revision to Diff 45030.Feb 6 2024, 23:20

Updated integration tests, however subject to upcoming alignment with react-router-dom refactors

Harbormaster completed remote builds in B26980: Diff 45030.Feb 6 2024, 23:24
emack abandoned this revision.Feb 24 2024, 11:41

Implemented via D15420

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
Configure/
138 lines
__tests__/
98 lines
Send/
fixtures/
6 lines

Diff 45030

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Configure/Configure.js

Loading...
View Options

cashtab/src/components/Configure/__tests__/Configure.test.js

Loading...
View Options

cashtab/src/components/Send/fixtures/mocks.js

Loading...