This diff replaces all uses of Notification.js functions in Configure.js with direct calls to the antd notification component, which happens to all be related to the Contact List feature.
Also integration tests added for this component.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- configureNotifs
- Lint
Lint Errors Severity Location Code Message Error cashtab/src/components/Configure/__tests__/Configure.test.js:70 ESLINT etc/no-commented-out-code Error cashtab/src/components/Configure/__tests__/Configure.test.js:95 ESLINT etc/no-commented-out-code - Unit
No Test Coverage - Build Status
Buildable 26900 Build 53367: Build Diff cashtab-tests Build 53366: arc lint + arc unit
Event Timeline
Comment Actions
Added initial integration test, still need to mock localForage when a localForage mock can't be passed in as a function arg.
Comment Actions
Updated integration tests, however subject to upcoming alignment with react-router-dom refactors