[Chronik] Fix `TxTokenData::from_db`
ClosedPublic
Actions

Authored by tobias_ruck on Feb 8 2024, 15:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3fbd43e1bdea: [Chronik] Fix `TxTokenData::from_db`

Summary

This currently uses ColoredTx::default() (with outputs = []) when color_tx returns None, which is incorrect, correct is a Vec of None of size tx.outputs.len().

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Feb 8 2024, 15:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2024, 15:39

tobias_ruck requested review of this revision.Feb 8 2024, 15:39

Harbormaster completed remote builds in B27005: Diff 45064.Feb 8 2024, 15:59

Fabien accepted this revision.Feb 11 2024, 10:13

This revision is now accepted and ready to land.Feb 11 2024, 10:13

Closed by commit rABC3fbd43e1bdea: [Chronik] Fix `TxTokenData::from_db` (authored by tobias_ruck). · Explain WhyFeb 12 2024, 12:41

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC3fbd43e1bdea: [Chronik] Fix `TxTokenData::from_db`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-indexer/

src/

query/

tx_token_data.rs

5 lines

Diff 45156

View Options

chronik/chronik-indexer/src/query/tx_token_data.rs

[Chronik] Fix `TxTokenData::from_db`ClosedPublicActions