Page MenuHomePhabricator

Bump clang-format version to 16.
Needs RevisionPublic

Authored by deadalnix on Feb 11 2024, 15:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Version 12 is not shipped by default on most distros.

I formatted a couple of files to check it works properly.

Test Plan

\o/

Event Timeline

deadalnix updated this revision to Diff 45136.

Fix regex

Fabien requested changes to this revision.Feb 12 2024, 08:30
Fabien added a subscriber: Fabien.

Please also update the CONTRIBUTING instructions to reflect the new version

arcanist/linter/ClangFormatLinter.php
61 ↗(On Diff #45136)

Why did you remove this ? AFAIK there is no guarantee that clang-format 17 or 18 produce the same output, so this could cause linting conflicts

This revision now requires changes to proceed.Feb 12 2024, 08:30