build: Add ability to build qt in depends with -stdlib=libc++
Needs RevisionPublic
Actions

Authored by PiRK on Feb 12 2024, 12:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

This is a backport of core#22814 and core#27314
Depends on D15425
Note that an intermediate PR core#25838 was already backported in D14065

Test Plan

guix build, gitian builds

Diff Detail

Repository

rABC Bitcoin ABC

Branch

funcs_mk

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27078
Build 53722: Build Diff
Build 53721: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 12 2024, 12:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2024, 12:12

teamcity edited the summary of this revision. (Show Details)Feb 12 2024, 12:12

Harbormaster completed remote builds in B27078: Diff 45151.Feb 12 2024, 12:12

@bot gitian-linux gitian-osx gitian-win

teamcity awarded a token.Feb 12 2024, 12:13

PiRK published this revision for review.Feb 12 2024, 15:25

PiRK mentioned this in D15425: build: Make $(package)_*_env available to all $(package)_*_cmds.

PiRK added a child revision: D15427: build: disable more optional components when building qt.Feb 12 2024, 16:13

The test plan does not cover the changes

This revision now requires changes to proceed.Feb 12 2024, 17:27

This actually does not work

make -C depends CC=clang CXX='clang++' works

make -C depends CC=clang CXX='clang++ -stdlib=libc++' fails with:

In file included from /home/pierre/dev/bitcoin-abc/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-e96183bb546/qtbase/include/QtCore/qglobal.h:1:
/home/pierre/dev/bitcoin-abc/depends/work/build/x86_64-pc-linux-gnu/qt/5.15.5-e96183bb546/qtbase/include/QtCore/../../src/corelib/global/qglobal.h:45:12: fatal error: 'type_traits' file not found
#  include <type_traits>
           ^~~~~~~~~~~~~
1 error generated.
gmake[1]: *** [Makefile:250: main.o] Error 1

PiRK mentioned this in D15428: remove unneeded includes when building without BIP70.Feb 13 2024, 16:05

PiRK removed a child revision: D15427: build: disable more optional components when building qt.Feb 13 2024, 16:06