Page MenuHomePhabricator
Differential D15469

[depends] Properly remove the native protobuf libraries
ClosedPublic
Actions

Authored by Fabien on Feb 16 2024, 15:14.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCcc614b17951b: [depends] Properly remove the native protobuf libraries
Summary

Depending on the architecture the installation can put libs in lib/, lib32/ or lib64/. Make sure to remove them all in the postprocessing step.

Test Plan

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
delete_native_protobuf_libs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27194
Build 53953: Build Diff
Build 53952: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 16 2024, 15:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 16 2024, 15:14
Fabien requested review of this revision.Feb 16 2024, 15:14
Harbormaster completed remote builds in B27194: Diff 45312.Feb 16 2024, 15:15
Fabien retitled this revision from [depends] Properly remove the native libraries to [depends] Properly remove the native protobuf libraries.Feb 16 2024, 15:19
PiRK accepted this revision.Feb 16 2024, 15:49
PiRK added a subscriber: PiRK.

This fixes the aarch64 guix build in D15457

This revision is now accepted and ready to land.Feb 16 2024, 15:49
Closed by commit rABCcc614b17951b: [depends] Properly remove the native protobuf libraries (authored by Fabien). · Explain WhyFeb 16 2024, 19:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCcc614b17951b: [depends] Properly remove the native protobuf libraries.
PiRK mentioned this in D15457: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu.Feb 17 2024, 14:46

Revision Contents
Changeset List

PathSize
depends/
packages/
2 lines

Diff 45312

View Options

depends/packages/native_protobuf.mk

Loading...