Page MenuHomePhabricator
Differential D15474

[Cashtab] Apply standardized test wrappers to App.test.js
ClosedPublic
Actions

Authored by bytesofman on Feb 17 2024, 13:29.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC0f8f0d53943e: [Cashtab] Apply standardized test wrappers to App.test.js
Summary

As a precursor to combining the app integration tests into one file, update the original tests to use new standardized wrappers

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update-app-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27211
Build 53986: Build Diffcashtab-tests
Build 53985: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 17 2024, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2024, 13:29
Harbormaster completed remote builds in B27210: Diff 45334.Feb 17 2024, 13:29
bytesofman updated this revision to Diff 45335.Feb 17 2024, 13:30

lint, version bump

Harbormaster completed remote builds in B27211: Diff 45335.Feb 17 2024, 13:33
bytesofman published this revision for review.Feb 17 2024, 13:41
emack added a subscriber: emack.Feb 18 2024, 06:31
emack added inline comments.
cashtab/src/components/__tests__/App.test.js
80

Does the absence of the route param result in this wrapper defaulting to the App (i.e. home) route?

bytesofman marked an inline comment as done.Feb 18 2024, 13:32
bytesofman added inline comments.
cashtab/src/components/__tests__/App.test.js
80

/wallet is specified as a default param in CashtabTestWrapper.js

emack accepted this revision.Feb 19 2024, 05:39
This revision is now accepted and ready to land.Feb 19 2024, 05:39
Closed by commit rABC0f8f0d53943e: [Cashtab] Apply standardized test wrappers to App.test.js (authored by bytesofman). · Explain WhyFeb 19 2024, 15:57
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABC0f8f0d53943e: [Cashtab] Apply standardized test wrappers to App.test.js.

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
__tests__/
92 lines

Diff 45335

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/__tests__/App.test.js

Loading...