Page MenuHomePhabricator
Differential D15551

[Chronik] Check rustup-init.sh hash before executing
ClosedPublic
Actions

Authored by tobias_ruck on Feb 26 2024, 14:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaf35ded0bc2b: [Chronik] Check rustup-init.sh hash before executing
Summary

Currently we just download a shell script from the interwebs and execute it, which is not good

Test Plan

./install-dependencies-bullseye.sh in the ABC docker container

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-check-rustup-init-hash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27429
Build 54421: Build Diff
Build 54420: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Feb 26 2024, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2024, 14:58
tobias_ruck requested review of this revision.Feb 26 2024, 14:58
Harbormaster completed remote builds in B27423: Diff 45613.Feb 26 2024, 14:59
tobias_ruck added a comment.Feb 26 2024, 15:02

@bot build-chronik

teamcity awarded a token.Feb 26 2024, 15:03
teamcity added a comment.Feb 26 2024, 15:10
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 45615.Feb 26 2024, 15:13

remove --

Harbormaster completed remote builds in B27425: Diff 45615.Feb 26 2024, 15:13
tobias_ruck added a comment.Feb 26 2024, 15:13

@bot build-chronik

teamcity updated a token.Feb 26 2024, 15:13
Fabien requested changes to this revision.Feb 26 2024, 15:25
Fabien added inline comments.
contrib/utils/install-dependencies-bullseye.sh
171 ↗(On Diff #45615)

This will still pull the latest version, so at some point the sum will not match. See gitian-linux.yml

This revision now requires changes to proceed.Feb 26 2024, 15:25
tobias_ruck updated this revision to Diff 45622.Feb 26 2024, 15:31

do it like they do it on the gitian-linux.yml

Harbormaster completed remote builds in B27428: Diff 45622.Feb 26 2024, 15:31
tobias_ruck updated this revision to Diff 45623.Feb 26 2024, 15:33

fix comments

Harbormaster completed remote builds in B27429: Diff 45623.Feb 26 2024, 15:33
tobias_ruck updated this revision to Diff 45624.Feb 26 2024, 15:33

fix order of commands

Harbormaster completed remote builds in B27430: Diff 45624.Feb 26 2024, 15:33
tobias_ruck added a comment.Feb 26 2024, 15:34

@bot build-chronik

teamcity updated a token.Feb 26 2024, 15:34
Fabien accepted this revision.Feb 26 2024, 15:37
This revision is now accepted and ready to land.Feb 26 2024, 15:37
teamcity added a comment.Feb 26 2024, 15:53
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Closed by commit rABCaf35ded0bc2b: [Chronik] Check rustup-init.sh hash before executing (authored by tobias_ruck). · Explain WhyFeb 26 2024, 16:35
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCaf35ded0bc2b: [Chronik] Check rustup-init.sh hash before executing.

Revision Contents
Changeset List

PathSize
contrib/
utils/
5 lines

Diff 45623

View Options

contrib/utils/install-dependencies-bullseye.sh

Loading...