T3444
Implement new standardized test wrapper in SendToken tests. Stop using data-testid in SendToken tests and delete from SendToken.
Update placeholder text for Burn to improve both the test and the UI.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC9693acd7dc34: [Cashtab] Update SendToken tests to new standardized wrapper
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- update-etoken-tests
- Lint
Lint Errors Severity Location Code Message Error cashtab/src/components/Send/__tests__/SendToken.test.js:15 ESLINT no-unused-vars Error cashtab/src/components/Send/__tests__/SendToken.test.js:53 ESLINT no-unused-vars - Unit
No Test Coverage - Build Status
Buildable 27464 Build 54491: Build Diff cashtab-tests Build 54490: arc lint + arc unit
Event Timeline
| cashtab/src/components/Send/__tests__/SendToken.test.js | ||
|---|---|---|
| 110–127 ↗ | (On Diff #45669) | This data is duplicated in most tests in this diff, with no differences AFAICT. Can't it be assigned to a variable in the outer scope? |
| cashtab/src/components/Send/__tests__/SendToken.test.js | ||
|---|---|---|
| 110–127 ↗ | (On Diff #45669) | Good call. I was able to move the mock creation steps there. However, render is not allowed to go in a beforeEach step |