[Cashtab] Adjust TRIGGER_UTXO_REFRESH_INTERVAL_MS to prevent multiple calls to update
ClosedPublic
Actions

Authored by bytesofman on Feb 27 2024, 23:18.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCfcfdd9a3ad8d: [Cashtab] Adjust TRIGGER_UTXO_REFRESH_INTERVAL_MS to prevent multiple calls to…

Summary

Have noticed Cashtab load times slowing down. Adding some log statements, could tell the update routine was getting called several times before the interval readjusted.

This is probably due to the React upgrade.

The current system in Cashtab is not the right way to refresh the wallet. We should only call update when we need to, i.e. on app startup and when the wallet receives tx notifications from the websocket. However, some additional refactor work needs to be done for this approach, and the issue is impacting load times in prod rightnow.

Patch while work out the optimization.

Test Plan

npm test, check out dev site at https://cashtab-local-dev.netlify.app/ which has a console.log statement and confirm update called only one time

Diff Detail

Repository

rABC Bitcoin ABC

Branch

better-startup-wallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27479
Build 54521: Build Diff	cashtab-tests
Build 54520: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 27 2024, 23:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2024, 23:18

Harbormaster completed remote builds in B27479: Diff 45687.Feb 27 2024, 23:22

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useWallet hook rendering in different localforage states Cashtab loads wallet, settings, cache, and contactlist from localforage to context if they are present ======
Error: expect(received).toBe(expected) // Object.is equality

Expected: 10
Received: 50
    at Object.toBe (/work/cashtab/src/hooks/__tests__/useWalletStorage.test.js:61:54)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Each failure log is accessible here:
CashTab Unit Tests: useWallet hook rendering in different localforage states Cashtab loads wallet, settings, cache, and contactlist from localforage to context if they are present