Page MenuHomePhabricator
Differential D15602

[guix] produce the NSIS installer when building for Windows
ClosedPublic
Actions

Authored by PiRK on Mar 1 2024, 15:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf14a16c626ba: [guix] produce the NSIS installer when building for Windows
Summary

and produce a .zip rather than a .tar.gz for windows, without forgetting .dll files (same procedure as gitian-win.yml)

and show the sha256 checksums at the end of the build

Test Plan

HOSTS="x86_64-w64-mingw32 x86_64-linux-gnu" contrib/guix/guix-build

Check the content of the output directory.

Test the installer with wine

Diff Detail

Repository
rABC Bitcoin ABC
Branch
guix_win_package
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27579
Build 54721: Build Diff
Build 54720: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 1 2024, 15:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2024, 15:39
Harbormaster completed remote builds in B27575: Diff 45813.Mar 1 2024, 15:39
PiRK updated this revision to Diff 45814.Mar 1 2024, 15:43
PiRK edited the test plan for this revision. (Show Details)

fix linux host name in test plan, don't forget ;; in case

Harbormaster completed remote builds in B27576: Diff 45814.Mar 1 2024, 15:43
PiRK published this revision for review.Mar 1 2024, 15:54
Fabien requested changes to this revision.Mar 1 2024, 17:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/guix/libexec/build.sh
343 ↗(On Diff #45814)

Please move this line in the case as well, it's not common to all platforms (it's not used for osx)

381 ↗(On Diff #45814)

Macro likestamp:

This revision now requires changes to proceed.Mar 1 2024, 17:09
PiRK updated this revision to Diff 45819.Mar 1 2024, 18:59

ninja install-debug only for windows and linux

Harbormaster completed remote builds in B27579: Diff 45819.Mar 1 2024, 18:59
Fabien accepted this revision.Mar 1 2024, 19:16
This revision is now accepted and ready to land.Mar 1 2024, 19:16
Closed by commit rABCf14a16c626ba: [guix] produce the NSIS installer when building for Windows (authored by PiRK). · Explain WhyMar 1 2024, 19:39
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf14a16c626ba: [guix] produce the NSIS installer when building for Windows.
Fabien added a child revision: D15603: [guix] Build the OSX DMG.Mar 1 2024, 20:20
Fabien removed a child revision: D15603: [guix] Build the OSX DMG.Mar 1 2024, 20:22

Revision Contents
Changeset List

PathSize
contrib/
guix/
libexec/
28 lines

Diff 45819

View Options

contrib/guix/libexec/build.sh

Loading...