Page MenuHomePhabricator
Differential D15603

[guix] Build the OSX DMG
ClosedPublic
Actions

Authored by Fabien on Mar 1 2024, 20:20.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC4d9c174a3a3d: [guix] Build the OSX DMG
Summary

Generate the OSX DGM image via GUIX. After this GUIX achieves feature parity with Gitian.

Test Plan
HOSTS=x86_64-apple-darwin ./contrib/guix/guix-build

Diff Detail

Repository
rABC Bitcoin ABC
Branch
osx_dmg_guix
Lint
Lint Passed
SeverityLocationCodeMessage
Advicecontrib/guix/libexec/build.sh:417SC2185ShellCheck found an issue:
Unit
No Test Coverage
Build Status
Buildable 27582
Build 54727: Build Diff
Build 54726: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 1 2024, 20:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2024, 20:20
Fabien requested review of this revision.Mar 1 2024, 20:20
Harbormaster completed remote builds in B27582: Diff 45824.Mar 1 2024, 20:20
Fabien updated this revision to Diff 45825.Mar 1 2024, 20:22

Rebase

Harbormaster completed remote builds in B27583: Diff 45825.Mar 1 2024, 20:22
Fabien removed a parent revision: D15602: [guix] produce the NSIS installer when building for Windows.Mar 1 2024, 20:22
Fabien edited the summary of this revision. (Show Details)
Fabien updated this revision to Diff 45826.Mar 1 2024, 20:23

Fix shellcheck

Harbormaster completed remote builds in B27584: Diff 45826.Mar 1 2024, 20:24
PiRK accepted this revision.Mar 2 2024, 08:00
This revision is now accepted and ready to land.Mar 2 2024, 08:00
PiRK added a comment.Mar 2 2024, 08:04

It works. And apparently xorrisofs is on the path, we don't need -DXORRISO_EXECUTABLE=

You can remove line 310, or I'll do it in a separate diff

PiRK added a comment.Mar 2 2024, 08:15

xorriso is going away if we backport https://github.com/bitcoin/bitcoin/pull/28432 (but this adds an extra step for the user: dragging the .app into the Applications folder)

Closed by commit rABC4d9c174a3a3d: [guix] Build the OSX DMG (authored by Fabien). · Explain WhyMar 2 2024, 10:05
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4d9c174a3a3d: [guix] Build the OSX DMG.

Revision Contents
Changeset List

PathSize
contrib/
guix/
libexec/
26 lines

Diff 45824

View Options

contrib/guix/libexec/build.sh

Loading...