Page MenuHomePhabricator
Differential D15610

[Cashtab] Replace conflicting functions with more comprehensive validation function
ClosedPublic
Actions

Authored by bytesofman on Mar 2 2024, 15:04.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCe9664406fc24: [Cashtab] Replace conflicting functions with more comprehensive validation…
Summary

We should only have cashtab wallet validation function. We have two because there were in the past edge cases where a wallet was "valid", as in, it would work in Cashtab, but we still wanted to migrate it, e.g. to change the format of the address.

Implement the more comprehensive validation function everywhere.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallet-validation-consolidate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27606
Build 54775: Build Diffcashtab-tests
Build 54774: arc lint + arc unit

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
5 lines
hooks/
9 lines
utils/
__mocks__/
3564 lines
__tests__/
76 lines
41 lines

Diff 45855

View Options

cashtab/src/components/App.js

Loading...
View Options

cashtab/src/hooks/useWallet.js

Loading...
View Options

cashtab/src/utils/__mocks__/mockLegacyWalletsUtils.js

Loading...
View Options

cashtab/src/utils/__mocks__/mockStoredWallets.js

Loading...
View Options

cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...