Page MenuHomePhabricator
Differential D15615

[mock-chronik-client] Install mock-chronik-client dependencies before running tests that require them
ClosedPublic
Actions

Authored by bytesofman on Mar 3 2024, 21:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1566d8f38e2c: [mock-chronik-client] Install mock-chronik-client dependencies before running…
Summary

Install mock-chronik-client deps before running js-mocha test suite in repo that depends on them

Test Plan

Test on js-mocha suite that does not require mock-chronik-client: ./contrib/teamcity/build-configurations.py ecashaddrjs-tests
Test on js-mocha suite that does require mock-chronik-client: ./contrib/teamcity/build-configurations.py ecash-herald-tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revert-mcc-ci
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27628
Build 54819: Build Diff
Build 54818: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 3 2024, 21:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2024, 21:59
Harbormaster completed remote builds in B27616: Diff 45868.Mar 3 2024, 21:59
bytesofman published this revision for review.Mar 3 2024, 22:00
Fabien requested changes to this revision.Mar 4 2024, 09:02
Fabien added a subscriber: Fabien.

This is a bad workflow because now only people with write access to the npm repo can develop on any app that will require a change to the mock and push the RC. This is a clear move backward.

This revision now requires changes to proceed.Mar 4 2024, 09:02
bytesofman updated this revision to Diff 45882.Mar 4 2024, 12:56

Modify templates to conditionally install mock-chronik-client deps if required

Harbormaster completed remote builds in B27627: Diff 45882.Mar 4 2024, 12:56
bytesofman updated this revision to Diff 45883.Mar 4 2024, 12:56

lint

Harbormaster completed remote builds in B27628: Diff 45883.Mar 4 2024, 12:56
bytesofman updated this revision to Diff 45884.Mar 4 2024, 12:58

specify DEPENDS_MOCK_CHRONIK_CLIENT: "false" if unused

Harbormaster completed remote builds in B27629: Diff 45884.Mar 4 2024, 12:59
bytesofman retitled this revision from [mock-chronik-client] Do not run CI on impacted modules on repo changes to [mock-chronik-client] Install mock-chronik-client dependencies before running tests that require them.Mar 4 2024, 13:00
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
bytesofman added inline comments.Mar 4 2024, 13:03
contrib/teamcity/build-configurations.yml
735 ↗(On Diff #45884)

I was not able to get this to work setting the var as a bool (vs string "true" or "false"). Probably due to lack of expertise with bash but mb something to do with how this is passed to the script.

bytesofman mentioned this in D15613: [mock-chronik-client] Support sub/unsub address method for ws.Mar 4 2024, 13:08
Fabien accepted this revision.Mar 5 2024, 09:10
Fabien added inline comments.
contrib/teamcity/build-configurations.yml
74 ↗(On Diff #45884)
783 ↗(On Diff #45884)

You can just omit it instead of setting it to false (note this is required to be empty with the suggested -n change otherwise false will be interpreted as true)

This revision is now accepted and ready to land.Mar 5 2024, 09:10
Closed by commit rABC1566d8f38e2c: [mock-chronik-client] Install mock-chronik-client dependencies before running… (authored by bytesofman). · Explain WhyMar 5 2024, 14:13
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC1566d8f38e2c: [mock-chronik-client] Install mock-chronik-client dependencies before running….

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
21 lines

Diff 45883

View Options

contrib/teamcity/build-configurations.yml

Loading...