Add overlooked ws.unsubscribe feature to mocked-chronik-client
Clean up ws unit tests which, through bugs, made it look like this feature existed.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCb3f29c79ce36: [mock-chronik-client] Support ws.unsubscribe
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- mcc-support-unsub
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 27677 Build 54917: Build Diff token-server-tests · app-dev-examples · alias-server-tests · mock-chronik-client-tests · cashtab-tests · ecash-herald-tests Build 54916: arc lint + arc unit
Event Timeline
| apps/mock-chronik-client/test/index.test.js | ||
|---|---|---|
| 180 | this isn't testing what it looks like it's testing if we want to enable testing of the ws receiving and responding to msgs, would take more work here. It is probably not doable, at least not in a way where it is helpful to tests. Testing actual websocket imo would best be done using bridged py regtest mocha integration tests like those in modules/chronik-client | |
| apps/mock-chronik-client/index.js | ||
|---|---|---|
| 104 | we do this in unsubscribeFromAddress here, which is the function introduced by D15613. I added a unit test here to confirm this. For the subscribe function -- let's do that in a separate diff. It is going to change and become subscribeToScript to support in-node chronik tests. For now, it is modeled on the NNG one -- still used in Cashtab and still tested this way -- which does not have this behavior. | |
| apps/mock-chronik-client/test/index.test.js | ||
|---|---|---|
| 232 ↗ | (On Diff #45951) | added test to confirm chronik-client in-node behavior |