Page MenuHomePhabricator
Differential D15656

[e.cash] Add extension to wallet page
ClosedPublic
Actions

Authored by emack on Mar 8 2024, 13:42.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC94450f474e27: [e.cash] Add extension to wallet page
Summary

Add the cashtab extension to the wallet page otherwise it's prone to users googling up a scam wallet.

Test Plan

preview the wallet page, click on the extension link

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtabExtensionLink
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27777
Build 55114: Build Diff
Build 55113: arc lint + arc unit

Event Timeline

emack created this revision.Mar 8 2024, 13:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2024, 13:42
emack requested review of this revision.Mar 8 2024, 13:42
Harbormaster completed remote builds in B27741: Diff 46029.Mar 8 2024, 13:42
bytesofman added a comment.Mar 8 2024, 13:43

@bot preview-e.cash

teamcity awarded a token.Mar 8 2024, 13:43
teamcity added a comment.Mar 8 2024, 13:54

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.63:41030 for the next 60 minutes.

bytesofman requested changes to this revision.Mar 8 2024, 13:59

can you use the Cashtab extension image from https://www.bitcoinabc.org/ecash/ ?

it's hard to differentiate between these tiles.

image.png (573×959 px, 73 KB)

image.png (196×581 px, 12 KB)

This revision now requires changes to proceed.Mar 8 2024, 13:59
emack updated this revision to Diff 46073.Mar 9 2024, 02:50

Updated wed/extension logos and wording.

Harbormaster completed remote builds in B27777: Diff 46073.Mar 9 2024, 02:50
emack added a comment.Mar 9 2024, 02:50

image.png (454×982 px, 84 KB)

bytesofman added a comment.Mar 9 2024, 05:21

@bot preview-e.cash

teamcity updated a token.Mar 9 2024, 05:21
teamcity added a comment.Mar 9 2024, 05:26

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.89.41.69:41766 for the next 60 minutes.

bytesofman accepted this revision.Mar 9 2024, 05:28
This revision is now accepted and ready to land.Mar 9 2024, 05:28
Closed by commit rABC94450f474e27: [e.cash] Add extension to wallet page (authored by emack). · Explain WhyMar 9 2024, 05:30
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC94450f474e27: [e.cash] Add extension to wallet page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
data/
14 lines
public/
images/

Diff 46073

View Options

web/e.cash/data/wallets.js

Loading...
View Options

web/e.cash/public/images/cashtab-extension.png

Loading...
View Options

web/e.cash/public/images/cashtab.png

Loading...