Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0c5226015df3: [Cashtab] Deprecate api-only app mgmt methods

Summary

Cashtab no longer has API-only functionality. Deprecate legacy tx notifications for disconnected websocket runtime.

Test Plan

npm test
grep -r usePrevious src/ and no output

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 8 2024, 18:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2024, 18:35

Harbormaster completed remote builds in B27751: Diff 46043.Mar 8 2024, 18:38

rebase

Harbormaster completed remote builds in B27753: Diff 46045.Mar 8 2024, 18:44

bytesofman published this revision for review.Mar 8 2024, 19:14

bytesofman mentioned this in D15662: [Cashtab] Change wallet structure to store balanceSats as number instead of balances as object.

PiRK accepted this revision.Mar 8 2024, 20:05

This revision is now accepted and ready to land.Mar 8 2024, 20:05

rebase on master

bytesofman edited the summary of this revision. (Show Details)Mar 8 2024, 22:30

remove usePrevious hook (now unused)

bytesofman edited the test plan for this revision. (Show Details)Mar 8 2024, 22:32

bytesofman removed a parent revision: D15662: [Cashtab] Change wallet structure to store balanceSats as number instead of balances as object.

Harbormaster completed remote builds in B27766: Diff 46060.Mar 8 2024, 22:43

Harbormaster completed remote builds in B27767: Diff 46061.Mar 8 2024, 22:46

Closed by commit rABC0c5226015df3: [Cashtab] Deprecate api-only app mgmt methods (authored by bytesofman). · Explain WhyMar 8 2024, 22:51

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC0c5226015df3: [Cashtab] Deprecate api-only app mgmt methods.

[Cashtab] Deprecate api-only app mgmt methods
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 46063

cashtab/package-lock.json

cashtab/package.json

cashtab/src/hooks/usePrevious.js

cashtab/src/hooks/useWallet.js

cashtab/src/utils/mocks/chronikWs.js

cashtab/src/utils/tests/cashMethods.test.js

cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate api-only app mgmt methodsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46063

cashtab/package-lock.json

cashtab/package.json

cashtab/src/hooks/usePrevious.js

cashtab/src/hooks/useWallet.js

cashtab/src/utils/__mocks__/chronikWs.js

cashtab/src/utils/__tests__/cashMethods.test.js

cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate api-only app mgmt methods
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/utils/mocks/chronikWs.js

cashtab/src/utils/tests/cashMethods.test.js