Page MenuHomePhabricator
Differential D15664

[chronik-client] Add line breaks to README changelog
ClosedPublic
Actions

Authored by bytesofman on Mar 8 2024, 19:38.

Details

Reviewers
Fabien
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC43d842c15439: [chronik-client] Add line breaks to README changelog
Summary

The changelog is not being rendered with line breaks in between versions. Add them.

Test Plan

Copy paste to https://markdownlivepreview.com/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 8 2024, 19:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2024, 19:38
Harbormaster completed remote builds in B27756: Diff 46048.Mar 8 2024, 19:46
teamcity added a comment.Mar 8 2024, 19:46
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 46070.Mar 9 2024, 00:02

rebase

Harbormaster completed remote builds in B27774: Diff 46070.Mar 9 2024, 00:10
teamcity added a comment.Mar 9 2024, 00:10
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 46072.Mar 9 2024, 00:34

rebase

Harbormaster completed remote builds in B27776: Diff 46072.Mar 9 2024, 00:39
bytesofman published this revision for review.Mar 9 2024, 05:09
Fabien accepted this revision.Mar 9 2024, 08:12
This revision is now accepted and ready to land.Mar 9 2024, 08:12
tobias_ruck requested changes to this revision.Mar 9 2024, 08:34
tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
modules/chronik-client/README.md
87 ↗(On Diff #46072)

How about adding bullet points instead?
Then people won't forget the \ as easily

This revision now requires changes to proceed.Mar 9 2024, 08:34
bytesofman updated this revision to Diff 46078.Mar 9 2024, 10:13

bullet points

Harbormaster completed remote builds in B27780: Diff 46078.Mar 9 2024, 10:19
teamcity added a comment.Mar 9 2024, 10:19
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 46081.Mar 9 2024, 10:22
bytesofman marked an inline comment as done.

rebase

Harbormaster completed remote builds in B27782: Diff 46081.Mar 9 2024, 10:39
tobias_ruck accepted this revision.Mar 11 2024, 11:21
This revision is now accepted and ready to land.Mar 11 2024, 11:21
Closed by commit rABC43d842c15439: [chronik-client] Add line breaks to README changelog (authored by bytesofman). · Explain WhyMar 11 2024, 12:30
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC43d842c15439: [chronik-client] Add line breaks to README changelog.

Revision Contents
Changeset List

PathSize
modules/
chronik-client/
38 lines

Diff 46087

View Options

modules/chronik-client/README.md

Loading...