refactor: Move ChainstateManager options into m_options struct
ClosedPublic
Actions

Authored by PiRK on Mar 11 2024, 14:59.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCc6e0d37e537e: refactor: Move ChainstateManager options into m_options struct

Summary

Move ChainstateManager options into m_options struct to simplify class
initialization, organize class members, and to name external option variables
differently than internal state variables.

This is a backport of core#25905

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 11 2024, 14:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2024, 14:59

PiRK requested review of this revision.Mar 11 2024, 14:59

teamcity edited the summary of this revision. (Show Details)Mar 11 2024, 14:59

Harbormaster completed remote builds in B27792: Diff 46095.Mar 11 2024, 15:16

bytesofman accepted this revision.Mar 11 2024, 22:52

This revision is now accepted and ready to land.Mar 11 2024, 22:52

Closed by commit rABCc6e0d37e537e: refactor: Move ChainstateManager options into m_options struct (authored by Ryan Ofsky <ryan@ofsky.org>, committed by PiRK). · Explain WhyMar 12 2024, 07:45

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc6e0d37e537e: refactor: Move ChainstateManager options into m_options struct.

Revision Contents
Changeset List

Path

Size

src/

validation.h

18 lines

validation.cpp

2 lines

Diff 46114

View Options

src/validation.h