Page MenuHomePhabricator
Differential D15696

rpc: Add EnsureArgsman helper
ClosedPublic
Actions

Authored by PiRK on Mar 14 2024, 10:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9aaf86775f68: rpc: Add EnsureArgsman helper
Summary

This refactor doesn't change anything for the rpc layer, but it helps a bit with removing gArgs

This is a backport of core#23936

Depends on D15695

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 14 2024, 10:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2024, 10:34
PiRK requested review of this revision.Mar 14 2024, 10:34
teamcity edited the summary of this revision. (Show Details)Mar 14 2024, 10:34
Harbormaster completed remote builds in B27859: Diff 46178.Mar 14 2024, 10:50
Fabien requested changes to this revision.Mar 14 2024, 13:02
Fabien added a subscriber: Fabien.

You're missing rpc/avalanche.cpp

This revision now requires changes to proceed.Mar 14 2024, 13:02
PiRK updated this revision to Diff 46194.Mar 14 2024, 13:33

remove a couple more gArgs in rpc code

grep -r "gArgs" src/rpc/
grep -r "\.args" src/rpc/
Harbormaster completed remote builds in B27870: Diff 46194.Mar 14 2024, 14:00
Fabien accepted this revision.Mar 14 2024, 14:25
This revision is now accepted and ready to land.Mar 14 2024, 14:25
Closed by commit rABC9aaf86775f68: rpc: Add EnsureArgsman helper (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 14 2024, 14:35
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9aaf86775f68: rpc: Add EnsureArgsman helper.

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
1 line
8 lines
9 lines
6 lines
7 lines
11 lines

Diff 46196

View Options

src/rpc/avalanche.cpp

Loading...
View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mempool.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/server_util.h

Loading...
View Options

src/rpc/server_util.cpp

Loading...