Page MenuHomePhabricator
Differential D15697

[mock-chronik-client] Match shape of subs in ws to ChronikClientNode for ChronikClientNode methods
ClosedPublic
Actions

Authored by bytesofman on Mar 14 2024, 12:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC623004961ac4: [mock-chronik-client] Match shape of subs in ws to ChronikClientNode for…
Summary

ChronikClientNode supports multiple types of ws subscription, so ws.subs is an object, not an array.

Match this shape for in-node users.

token-server uses in-node chronik-client but tests legacy shape to match mock behavior. Update token-server to test correct behavior.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Mar 14 2024, 12:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 14 2024, 12:32
bytesofman updated this revision to Diff 46185.Mar 14 2024, 12:34

match shape for block methods

bytesofman updated this revision to Diff 46186.Mar 14 2024, 12:35

update changelog, minor version bump

Harbormaster completed remote builds in B27862: Diff 46185.Mar 14 2024, 12:57
teamcity added a comment.Mar 14 2024, 12:57
Build Bitcoin ABC Diffs / Diff Testing (token-server-tests) failed.

Failed tests logs:

====== chronik/wsHandler.js: initializeWebsocket returns expected websocket object.chronik/wsHandler.js initializeWebsocket returns expected websocket object ======
AssertionError: false == true
AssertionError [ERR_ASSERTION]: false == true
    at Context.<anonymous> (test/chronik/wsHandler.test.ts:21:16)
    at Generator.next (<anonymous>)
    at fulfilled (test/chronik/wsHandler.test.ts:31:58)

      + expected - actual

      -false
      +true

Each failure log is accessible here:
chronik/wsHandler.js: initializeWebsocket returns expected websocket object.chronik/wsHandler.js initializeWebsocket returns expected websocket object

Harbormaster completed remote builds in B27861: Diff 46184.Mar 14 2024, 12:58
Harbormaster completed remote builds in B27863: Diff 46186.
teamcity added a comment.Mar 14 2024, 12:59
Build Bitcoin ABC Diffs / Diff Testing (token-server-tests) failed.

Failed tests logs:

====== chronik/wsHandler.js: initializeWebsocket returns expected websocket object.chronik/wsHandler.js initializeWebsocket returns expected websocket object ======
AssertionError: false == true
AssertionError [ERR_ASSERTION]: false == true
    at Context.<anonymous> (test/chronik/wsHandler.test.ts:21:16)
    at Generator.next (<anonymous>)
    at fulfilled (test/chronik/wsHandler.test.ts:31:58)

      + expected - actual

      -false
      +true

Each failure log is accessible here:
chronik/wsHandler.js: initializeWebsocket returns expected websocket object.chronik/wsHandler.js initializeWebsocket returns expected websocket object

bytesofman updated this revision to Diff 46192.Mar 14 2024, 13:20

Update test in token-server to match in-node shape

Harbormaster completed remote builds in B27868: Diff 46192.Mar 14 2024, 13:46
bytesofman published this revision for review.Mar 14 2024, 13:46
bytesofman edited the summary of this revision. (Show Details)
bytesofman mentioned this in D15693: [Cashtab] Use in-node chronik.Mar 14 2024, 16:48
PiRK accepted this revision.Mar 14 2024, 17:10
This revision is now accepted and ready to land.Mar 14 2024, 17:10
Closed by commit rABC623004961ac4: [mock-chronik-client] Match shape of subs in ws to ChronikClientNode for… (authored by bytesofman). · Explain WhyMar 14 2024, 17:38
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC623004961ac4: [mock-chronik-client] Match shape of subs in ws to ChronikClientNode for….

Revision Contents
Changeset List

PathSize
apps/
token-server/
16 lines
2 lines
test/
chronik/
2 lines
modules/
mock-chronik-client/
4 lines
34 lines
4 lines
2 lines
test/
18 lines

Diff 46200

View Options

apps/token-server/package-lock.json

Loading...
View Options

apps/token-server/package.json

Loading...
View Options

apps/token-server/test/chronik/wsHandler.test.ts

Loading...
View Options

modules/mock-chronik-client/README.md

Loading...
View Options

modules/mock-chronik-client/index.js

Loading...
View Options

modules/mock-chronik-client/package-lock.json

Loading...
View Options

modules/mock-chronik-client/package.json

Loading...
View Options

modules/mock-chronik-client/test/index.test.js

Loading...