Differential D15707

[chronik] Prevent potential port collision in chronik_serve
ClosedPublic
Actions

Authored by Fabien on Mar 15 2024, 09:08.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCadc17694f15b: [chronik] Prevent potential port collision in chronik_serve

Summary

The port 23456 is in the range of the ports used by the test framework itself so there is a risk it collides with another test.

Test Plan

./test/functional/test_runner.py chronik_serve

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_no_hardcoded_port_collision

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27884
Build 55319: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 55318: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 15 2024, 09:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 15 2024, 09:08

Fabien requested review of this revision.Mar 15 2024, 09:08

Harbormaster completed remote builds in B27884: Diff 46213.Mar 15 2024, 09:26

PiRK accepted this revision.Mar 15 2024, 09:55

This revision is now accepted and ready to land.Mar 15 2024, 09:55

Closed by commit rABCadc17694f15b: [chronik] Prevent potential port collision in chronik_serve (authored by Fabien). · Explain WhyMar 15 2024, 10:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCadc17694f15b: [chronik] Prevent potential port collision in chronik_serve.

Revision Contents
Changeset List

Path

Size

test/

functional/

chronik_serve.py

4 lines

Diff 46213

View Options

test/functional/chronik_serve.py

[chronik] Prevent potential port collision in chronik_serveClosedPublicActions