Differential D15730

[chronik] Make chronik_serve bind once to the same ip
ClosedPublic
Actions

Authored by Fabien on Mar 18 2024, 20:23.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa8e8f277059d: [chronik] Make chronik_serve bind once to the same ip

Summary

The datadir's default config file from the test framework always adds a binding to 127.0.0.1 which is not what the test is expecting.

Test Plan

./test/functional/test_runner.py chronik_serve

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_serve_single

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27927
Build 55404: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 55403: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 18 2024, 20:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2024, 20:23

Fabien requested review of this revision.Mar 18 2024, 20:23

@bot build-linux-arm build-linux-aarch64

teamcity awarded a token.Mar 18 2024, 20:31

Harbormaster completed remote builds in B27927: Diff 46279.Mar 18 2024, 20:45

The datadir always adds a binding to 127.0.0.1 which is not what the test is expecting.

-"datadir" +"test framework" or +"config file" ?

Otherwise LGTM, except for the confusing summary.

This revision is now accepted and ready to land.Mar 19 2024, 07:50

In D15730#355246, @PiRK wrote:

Otherwise LGTM, except for the confusing summary.

I edited the summary to avoid confusion

Closed by commit rABCa8e8f277059d: [chronik] Make chronik_serve bind once to the same ip (authored by Fabien). · Explain WhyMar 19 2024, 08:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa8e8f277059d: [chronik] Make chronik_serve bind once to the same ip.

Revision Contents
Changeset List

Path

Size

test/

functional/

chronik_serve.py

19 lines

Diff 46279

View Options

test/functional/chronik_serve.py

[chronik] Make chronik_serve bind once to the same ipClosedPublicActions