Page MenuHomePhabricator

validationcaches: Abolish arbitrary limit
ClosedPublic

Authored by PiRK on Mar 19 2024, 12:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf2314681f2d4: validationcaches: Abolish arbitrary limit
Summary
  1. -maxsigcachesize is a DEBUG_ONLY option
  1. Almost 7 years has passed since its semantics change in 830e3f3d027ba5c8121eed0f6a9ce99961352572 from "number of entries" to "number of mebibytes"
  1. A std::new_handler was added to the codebase after the original PR which introduced this limit, which will terminate immediately instead of causing trouble by being caught somewhere unexpected.

This is a partial backport of core#25527
https://github.com/bitcoin/bitcoin/pull/25527/commits/b370164b319df1a500b70694b077f92265a777fb

Depends on D15735

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable