test/lint/lint-circular-dependencies.sh
29 ↗	(On Diff #46484)	This one is a bit surprising. It was introduced in https://reviews.bitcoinabc.org/D15279, but the avalanche includes in txmempool.cpp don't seem to be mandatory.

Don't introduce the avalanche/processor -> validation -> txmempool -> avalanche/processor circular dependency

Fabien added inline comments.Mar 26 2024, 20:27

test/lint/lint-circular-dependencies.sh
29 ↗	(On Diff #46484)	Good catch, the includes are not needed and have been removed

Harbormaster completed remote builds in B28076: Diff 46489.Mar 26 2024, 20:45

PiRK accepted this revision.Mar 27 2024, 07:35

This revision is now accepted and ready to land.Mar 27 2024, 07:35

Closed by commit rABCd6b116b59875: Move DisconnectedBlockTransactions to its own file (authored by Fabien). · Explain WhyMar 27 2024, 13:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd6b116b59875: Move DisconnectedBlockTransactions to its own file.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

2 lines

kernel/

disconnected_transactions.h

172 lines

disconnected_transactions.cpp

222 lines

test/

mempool_tests.cpp

1 line

policyestimator_tests.cpp

1 line

validation_chainstatemanager_tests.cpp

1 line

txmempool.h

149 lines

txmempool.cpp

210 lines

validation.cpp

1 line

test/

lint/

lint-circular-dependencies.sh

3 lines

Diff 46501

View Options

src/CMakeLists.txt

View Options

src/kernel/disconnected_transactions.h

View Options

src/kernel/disconnected_transactions.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/test/validation_chainstatemanager_tests.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

src/validation.cpp

View Options

test/lint/lint-circular-dependencies.sh

Move DisconnectedBlockTransactions to its own fileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46501

src/CMakeLists.txt

src/kernel/disconnected_transactions.h

src/kernel/disconnected_transactions.cpp

src/test/mempool_tests.cpp

src/test/policyestimator_tests.cpp

src/test/validation_chainstatemanager_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.cpp

test/lint/lint-circular-dependencies.sh

Move DisconnectedBlockTransactions to its own file
ClosedPublic
Actions

Revision Contents
Changeset List