[Cashtab] Replace all console.log statements with error or info and remove debug logs
ClosedPublic
Actions

Authored by bytesofman on Mar 29 2024, 14:13.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC646b22d10827: [Cashtab] Replace all console.log statements with error or info and remove…

Summary

T3485

In this way, we can use console.log for debug logs -- then quickly test if any debug logs are remaining.

This diff also removes some lingering debug logs from various places in the app.

Test Plan

grep -r console.log src/ -- still a few left, but they are removed in D15804

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtab-no-console-logs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28178
Build 55901: Build Diff	cashtab-tests
Build 55900: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 29 2024, 14:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2024, 14:13

Harbormaster completed remote builds in B28163: Diff 46595.Mar 29 2024, 14:13

lint

bytesofman retitled this revision from [Cashtab] Replace all console.log statements with error or info to [Cashtab] Replace all console.log statements with error or info and remove debug logs.Mar 29 2024, 14:19

bytesofman edited the summary of this revision. (Show Details)

bytesofman published this revision for review.Mar 29 2024, 14:34

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Installing mock-chronik-client dependencies...
/work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests

added 236 packages, and audited 237 packages in 2s

35 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
/work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests

added 1718 packages, and audited 1719 packages in 31s

262 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@2.9.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Common/WalletLabel.js
  Line 55:15:  'walletName' is assigned a value but never used  no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Harbormaster completed remote builds in B28165: Diff 46597.Mar 29 2024, 14:39

In D15810#357484, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Installing mock-chronik-client dependencies...
/work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests

added 236 packages, and audited 237 packages in 2s

35 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
/work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests

added 1718 packages, and audited 1719 packages in 31s

262 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@2.9.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Common/WalletLabel.js
  Line 55:15:  'walletName' is assigned a value but never used  no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

fixed in rebase

rebase

Harbormaster completed remote builds in B28178: Diff 46612.Mar 29 2024, 23:05

grep -r console.log src/ -- still a few left, but they are removed in D15804

Still seeing two remaining in useImage even though D15804 has since landed

This revision now requires changes to proceed.Mar 30 2024, 07:25

In D15810#357697, @emack wrote:

grep -r console.log src/ -- still a few left, but they are removed in D15804

Still seeing two remaining in useImage even though D15804 has since landed