Broke send to many in D15776, as the send button will be disabled even if user input is correct.
Update validation function for disabling send button. Add an integration test for multisend to prevent this kind of oversight in the future.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC9f69b3db096e: [Cashtab] Patch send to many with improved validation
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- patch-multisend
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28177 Build 55899: Build Diff cashtab-tests Build 55898: arc lint + arc unit
Event Timeline
Comment Actions
It current enables the Send button when the aggregate send amount is exactly the same as the wallet balance, which shouldn't be the case because then there wouldn't be enough to pay for the txFee.
| cashtab/src/components/Send/__tests__/SendXec.test.js | ||
|---|---|---|
| 1531 | [insert Fabien's porno reaction about file size] | |
| cashtab/src/validation/fixtures/vectors.js | ||
| 118 | Needs an additional one where the aggregate multi send value exceeds balanceSats, or even just equals balanceSats as you'd need to factor in txFee. | |
Comment Actions
It current enables the Send button when the aggregate send amount is exactly the same as the wallet balance, which shouldn't be the case because then there wouldn't be enough to pay for the txFee.
This is true, but this is also an existing issue that also applies to send-to-one. Since multisend is currently broken in prod, this should be handled separately.
| cashtab/src/validation/fixtures/vectors.js | ||
|---|---|---|
| 118 | true but will do this in another diff. this is already an existing issue. this diff is really just "fix multisend in prod" | |