Details

Reviewers

Group Reviewers

Restricted Project

Summary

Add nBillableSizeWithDescendants and nBillableSizeWithAncestors to
CTxMempoolEntry to allow CBlockAssembler to mine transactions based
on fees calculated using the billable size of a package.

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mine-billing

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2909
Build 3922: Bitcoin ABC Buildbot (legacy)
Build 3921: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 19 2018, 20:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2018, 20:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a child revision: D1561: [qa] change bip68 sequence to use calculate_fee.Jul 19 2018, 20:27

schancel removed a child revision: D1561: [qa] change bip68 sequence to use calculate_fee.

schancel added a parent revision: D1486: Use a modified size for transaction minimum fee calculation..

schancel added a child revision: D1480: Tweak UTXO weight based agreed suggested costs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2909: Diff 4359!Jul 19 2018, 20:57

jasonbcox requested changes to this revision.Jul 20 2018, 05:10

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/txmempool.cpp
331	I noticed Amaury has been migrating code to use the more modern function-call style casting. I think it reads better, so please do that here and the line immediately above this one. Like `-int64_t(removeIt->GetBillableSize());`
397	int -> int64_t
402	Nit: Looks like this should be int64_t as well?
src/validation.h
59	This is per kB right? Please clarify the comment to reflect that.
test/functional/bip68-sequence.py
298	Looks like this may have been dependent on your other diff. Please correct that there if it's not landed already.

This revision now requires changes to proceed.Jul 20 2018, 05:10

schancel planned changes to this revision.Jul 20 2018, 16:54

schancel added inline comments.

src/txmempool.cpp
331	Good patch. I copy and pasted the code without noticing that.
test/functional/bip68-sequence.py
298	Yeah I caught it and fixed it. I still have a few other things to deal with though.