Differential D15837
[Cashtab] Parse mint txs Authored by bytesofman on Mar 31 2024, 22:02.
Details
Parse slpv1 mint txs Note: this is not a great implementation. It follows the pattern of existing tx history parsing. However, this is a bad pattern. I am working on a refactor but that will be a multi-part diff that will end up replacing the whole Tx component. Since the component will be replaced anyway, imo it is worth parsing these txs right now, even if the implementation is not great. Alternative is these txs are parsed as -0 XEC txs, confusing and wrong. npm test 
Diff Detail
Event TimelineComment Actions I'm getting little squares where there would have been -0 XECs. Is this a font thing?  Comment Actions
do you also see this on master? weird that it is showing up for the genesis tx as well Comment Actions
what's the name of this token? seems to be an existing issue in rendering some characters deployed to https://cashtab-local-dev.netlify.app/ I don't think this is introduced by this diff but we should still fix it, good timing since about to refactor this part of the codebase Comment Actions This is the same in master. The token in question https://explorer.e.cash/tx/c3ca196cc51acdcad5c73cd29392fadb631c26366c56ea7c5c9ac76d4df5f264 I did go HAM on its supply minting to quintellion a few times so not sure if this is a result of some sort of overflow somewhere in the front end? |