get all formdata inputs into one object

manage errors in the same way

now we get to lose all of these crazily-named state fields

and we only need one function to handle input and validation for the whole component

the 150 is a magic number. I assume it was implemented to keep processing times limited and prevent accidentaly enormous signing.

the bytecount is what really matters, but since this isn't really a spec limitation, I introduced a new constant limit of 200 to replace the magic number.

Cashtab isn't really optimized to support large msg signing, it's more mobile-first. So imo this is a good cutoff, we've never had complaints about 150.

tbh I don't think msg signing is used often at all. This will change when we make it the de facto way to sign into webapps with the extension. But the goal is to not have the user think about msg signing, just about how much more convenient it is than password mgmt.

Good point. In response to this review, I built it out with two switches. I tried two switches where only one can be enabled at a time, and also two switches where the user could see both fields at the same time.

Both cases ended up feeling a bit weird. If you can see both, then the verify switch is under the open sign form, and is not really obvious.

If you have two switches but can only see one, it's either weird to keep both switches at the top, or you have the same issue where the bottom switch (under forms) doesn't really stand out.

Since this screen will only ever have two modes, I customized the switch to be less "on/off" and more "sign/verify". Similar to the "equal" airdrop switch. I think it's the best of these options.

The switches for the SendToken page work and are modular, which is nice. But I still think it's a kind of temporary UX. Should be something like an accordion if we really want to allow only one thing at a time.

I thought about this but decided against it.

1. The usual use case for this screen is not checking a msg that you have signed yourself to see if it's valid. That is the usual dev case for us testing this component.
2. The user can now copy his own address from the wallet header. Maybe this is not super intuitive -- but it is more intuitive than the old way this screen worked (user had to open the "sign" collapse, copy the own address there, then paste it in collapse).

If it were really important to make it easy to verify own address, I would add a button there, or pre-populate the for that way. imo tho users don't really need to check if a msg they have signed has a valid signature, they already know this (they aren't JS devs rightly distrustful of their own software). Verify msg is mostly useful if you are checking on some other msg and address. So, keeping the input blank is imo the best UX.

In either case, this component still isn't really about UX. Sign/Verify msg is a power user feature. The UX we are chasing is "one click secure app login with signing a msg". This will need to be worked out in the extension.