Page MenuHomePhabricator

Use value_type in CDataStream where possible
ClosedPublic

Authored by PiRK on Apr 2 2024, 15:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd88558168af1: Use value_type in CDataStream where possible
Summary

Also, simplify unit tests with the CDataStream::str method.

This is a partial backport of core#23451
https://github.com/bitcoin/bitcoin/pull/23451/commits/fabe18d0b39b4b918bf60e3a313eaa36fb4067f2

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Apr 2 2024, 15:52
src/streams.h
288

The change to this line in the source material is incorrect (see discussion in the review). In our codebase there is a test that caught the issue.

still working on an issue in the last commit of the PR, let's wait before reviewing this

PiRK planned changes to this revision.Apr 2 2024, 16:02
PiRK requested review of this revision.Apr 3 2024, 07:45
This revision is now accepted and ready to land.Apr 4 2024, 07:41