Page MenuHomePhabricator
Differential D15899

[net] Don't create outbound connection to the same ip as an inbound
ClosedPublic
Actions

Authored by Fabien on Apr 5 2024, 07:24.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC233e2d7f0423: [net] Don't create outbound connection to the same ip as an inbound
Summary

This fixes a bug that has been introduced in D15850. The AlreadyConnectedToAddress() function needs to filter on IP only to prevent the node from initiating an outbound connection to a peer that is already connected as an inbound.

This is a partial revert of rABC02b4774d7c2400b7e5a6f63f2e1ed2d01192c33e.

Depends on D15898.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 5 2024, 07:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2024, 07:24
Fabien requested review of this revision.Apr 5 2024, 07:24
PiRK accepted this revision.Apr 5 2024, 07:31
This revision is now accepted and ready to land.Apr 5 2024, 07:31
This revision was landed with ongoing or failed builds.Apr 5 2024, 07:32
Closed by commit rABC233e2d7f0423: [net] Don't create outbound connection to the same ip as an inbound (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC233e2d7f0423: [net] Don't create outbound connection to the same ip as an inbound.
Harbormaster completed remote builds in B28340: Diff 46855.Apr 5 2024, 07:43

Revision Contents
Changeset List

PathSize
doc/
3 lines
src/
2 lines
test/
2 lines

Diff 46857

View Options

doc/release-notes.md

Loading...
View Options

src/net.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...