[e.cash] Add halving banner to navbar
ClosedPublic
Actions

Authored by johnkuney on Apr 5 2024, 21:40.

Details

Reviewers

bytesofman
Mengerian

Group Reviewers

Restricted Project

Commits

rABC3fb0d89e807c: [e.cash] Add halving banner to navbar

Summary

As discussed, adding a second banner to the navbar to show the blocks left until the halving

Test Plan

preview the site and check the banner looks good.
If the blockheight api calls fails it will read 'eCash halving is imminent!' instead.
Open to other ideas there

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Apr 5 2024, 21:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2024, 21:40

johnkuney requested review of this revision.Apr 5 2024, 21:40

Harbormaster completed remote builds in B28366: Diff 46893.Apr 5 2024, 21:40

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.89.41.69:41716 for the next 60 minutes.

this is better than nothing but isn't really a countdown. it's probably "good enough" for the landing page, arguably overkill to be subscribing to a websocket for this.

at any rate, this is better than what we have now. if we want to countdown, can add this sometime between now and the halvening.

alt: we could keep using the API and just check at some regular interval, say every minute.

This revision is now accepted and ready to land.Apr 5 2024, 22:36