Page MenuHomePhabricator

[e.cash] Add halving banner to navbar
ClosedPublic

Authored by johnkuney on Apr 5 2024, 21:40.

Details

Reviewers
bytesofman
Mengerian
Group Reviewers
Restricted Project
Commits
rABC3fb0d89e807c: [e.cash] Add halving banner to navbar
Summary

As discussed, adding a second banner to the navbar to show the blocks left until the halving

Test Plan

preview the site and check the banner looks good.
If the blockheight api calls fails it will read 'eCash halving is imminent!' instead.
Open to other ideas there

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

this is better than nothing but isn't really a countdown. it's probably "good enough" for the landing page, arguably overkill to be subscribing to a websocket for this.

at any rate, this is better than what we have now. if we want to countdown, can add this sometime between now and the halvening.

alt: we could keep using the API and just check at some regular interval, say every minute.

This revision is now accepted and ready to land.Apr 5 2024, 22:36
Mengerian added a subscriber: Mengerian.

Looks good to me

This revision was automatically updated to reflect the committed changes.