T2207
Use a custom select component instead of antd. Add a test to confirm it is working as expected.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC55b009441bd1: [Cashtab] Deprecate antd select from Configure screen
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- non-antd-select-config
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 28376 Build 56294: Build Diff cashtab-tests Build 56293: arc lint + arc unit
Event Timeline
| cashtab/src/components/Configure/__tests__/Configure.test.js | ||
|---|---|---|
| 678 ↗ | (On Diff #46907) | Add a check that the fiatCurrency setting within cashtabState has been updated. |
| cashtab/src/components/Configure/__tests__/Configure.test.js | ||
|---|---|---|
| 678 ↗ | (On Diff #46907) | Since this displayed value is controlled by cashtabState, want to avoid this (testing state directly instead of testing the impact of state on the component). In general with react testing library, we want to test the result -- i.e. how a component is rendered -- and not state directly. In Cashtab, we only test state directly in useWallet.test.js -- arguably, we could drop that, except it is useful for testing migrations and bootup (while also supplemented by testing the actual components in App.test.js) ref Added a localforage check since that should happen in parallel. |