Differential D15919
[Cashtab] Remove unused validation function Authored by bytesofman on Apr 6 2024, 23:14. Tags None Subscribers None
Details
In D15884, we tightened validation for contact list (only accept ecash: prefixed addresses). So, we stopped using this function. If we start accepting aliases, we need to convert them to addresses before storing them to keep app functionality straightforward. For now, this is not used anywhere, so get rid of it. npm test
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: Installing mock-chronik-client dependencies... /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 236 packages, and audited 237 packages in 2s 35 packages are looking for funding run `npm fund` for details found 0 vulnerabilities /work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 1718 packages, and audited 1719 packages in 29s 262 packages are looking for funding run `npm fund` for details 1 moderate severity vulnerability To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@2.23.0 build > node scripts/build.js Creating an optimized production build... Failed to compile. [eslint] src/validation/index.js Line 14:10: 'queryAliasServer' is defined but never used no-unused-vars Search for the keywords to learn more about each error. Build cashtab-tests failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: Installing mock-chronik-client dependencies... /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 236 packages, and audited 237 packages in 1s 35 packages are looking for funding run `npm fund` for details found 0 vulnerabilities /work/cashtab /work/modules/mock-chronik-client /work/abc-ci-builds/cashtab-tests added 1718 packages, and audited 1719 packages in 30s 262 packages are looking for funding run `npm fund` for details 1 moderate severity vulnerability To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@2.23.0 build > node scripts/build.js Creating an optimized production build... Failed to compile. [eslint] src/validation/index.js Line 14:10: 'queryAliasServer' is defined but never used no-unused-vars Search for the keywords to learn more about each error. Build cashtab-tests failed with exit code 1 Comment Actions note the CI failures are related to previous revs pushed before linting, current state is passing CI |