Page MenuHomePhabricator
Differential D15932

[ecash-lib] CI improvements for typescript projects
ClosedPublic
Actions

Authored by bytesofman on Apr 10 2024, 04:10.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC9b0df5a20cbb: [ecash-lib] CI improvements for typescript projects
Summary

Add support for running ecash-lib unit tests and building ecash-lib to CI

Since token-server is also a typescript project, add the introduced "test build" support there as well

Test Plan

./contrib/teamcity/build-configurations.py ecash-lib-tests
./contrib/teamcity/build-configurations.py token-server-tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-lib-headers
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28427
Build 56395: Build Diff
Build 56394: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 10 2024, 04:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2024, 04:10
Harbormaster completed remote builds in B28425: Diff 46972.Apr 10 2024, 04:10
bytesofman updated this revision to Diff 46973.Apr 10 2024, 04:10

lint

Harbormaster completed remote builds in B28426: Diff 46973.Apr 10 2024, 04:11
bytesofman retitled this revision from [ecash-lib] Add test and build to CI to [ecash-lib] CI improvements for typescript projects.Apr 10 2024, 04:11
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
bytesofman updated this revision to Diff 46974.Apr 10 2024, 04:14

back out rc version

Harbormaster completed remote builds in B28427: Diff 46974.Apr 10 2024, 04:14
bytesofman updated this revision to Diff 46975.Apr 10 2024, 04:15

header to js file

Harbormaster completed remote builds in B28428: Diff 46975.Apr 10 2024, 04:15
bytesofman published this revision for review.Apr 10 2024, 04:15
bytesofman added inline comments.
modules/ecash-lib/.nycrc
1 ↗(On Diff #46973)

https://www.npmjs.com/package/@istanbuljs/nyc-config-typescript

modules/ecash-lib/eslint.config.js
1 ↗(On Diff #46973)

TIL https://www.npmjs.com/package/typescript-eslint

will prob still have some issues, but eslint has always given me trouble with other typescript repos

bytesofman updated this revision to Diff 46983.Apr 10 2024, 05:41

gitignore fix

Harbormaster completed remote builds in B28436: Diff 46983.Apr 10 2024, 05:41
PiRK accepted this revision.Apr 10 2024, 08:47
This revision is now accepted and ready to land.Apr 10 2024, 08:47
Closed by commit rABC9b0df5a20cbb: [ecash-lib] CI improvements for typescript projects (authored by bytesofman). · Explain WhyApr 10 2024, 13:31
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC9b0df5a20cbb: [ecash-lib] CI improvements for typescript projects.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
18 lines
modules/
ecash-lib/
8 lines
15 lines
4 lines
12 lines
6564 lines
13 lines

Diff 46974

View Options

contrib/teamcity/build-configurations.yml

Loading...
View Options

modules/ecash-lib/.eslintignore

Loading...
View Options

modules/ecash-lib/.gitignore

Loading...
View Options

modules/ecash-lib/.nycrc

Loading...
View Options

modules/ecash-lib/eslint.config.js

Loading...
View Options

modules/ecash-lib/package-lock.json

Loading...
View Options

modules/ecash-lib/package.json

Loading...