Paths

Table of Contentst

Differential D15933

refactor: [index] Replace deprecated char with uint8_t in serialization
ClosedPublic
Actions

Authored by PiRK on Wed, Apr 10, 14:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6f5358fdff52: refactor: [index] Replace deprecated char with uint8_t in serialization

Summary

All char representations are serialized in the same way, however the char one is deprecated. Also, using uint8_t directly avoids casts.

This is a backport of core#21824

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Apr 10, 14:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 10, 14:44

PiRK requested review of this revision.Wed, Apr 10, 14:44

Harbormaster completed remote builds in B28440: Diff 46989.Wed, Apr 10, 14:44

PiRK added a child revision: D15934: span: Add BytePtr helper.Wed, Apr 10, 15:03

teamcity edited the summary of this revision. (Show Details)Wed, Apr 10, 21:16

rebase

Harbormaster completed remote builds in B28474: Diff 47028.Thu, Apr 11, 07:17

Fabien accepted this revision.Thu, Apr 11, 09:30

This revision is now accepted and ready to land.Thu, Apr 11, 09:30

Closed by commit rABC6f5358fdff52: refactor: [index] Replace deprecated char with uint8_t in serialization (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyThu, Apr 11, 10:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6f5358fdff52: refactor: [index] Replace deprecated char with uint8_t in serialization.

Revision Contents
Changeset List

Path

Size

src/

index/

2 lines

10 lines

10 lines

2 lines

Diff 47038

View Options

src/index/base.cpp

View Options

src/index/blockfilterindex.cpp

View Options

src/index/coinstatsindex.cpp

View Options

refactor: [index] Replace deprecated char with uint8_t in serializationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47038

src/index/base.cpp

src/index/blockfilterindex.cpp

src/index/coinstatsindex.cpp

src/index/txindex.cpp

refactor: [index] Replace deprecated char with uint8_t in serialization
ClosedPublic
Actions

Revision Contents
Changeset List