Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6060493fceb0: [ecash-lib] Add `pushBytesOp` to make a minimal bytes pushop

Summary

Script requires to use minimally encoded push ops. pushBytesOp creates a minimal Op for us that pushes the given bytes.

Depends on D15938.

Test Plan

npm run test && npm run build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-lib-pushbytesop

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28495
Build 56531: Build Diff	ecash-lib-tests
Build 56530: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 10 2024, 22:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2024, 22:55

tobias_ruck requested review of this revision.Apr 10 2024, 22:55

Harbormaster completed remote builds in B28461: Diff 47011.Apr 10 2024, 23:03

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

tobias_ruck edited the summary of this revision. (Show Details)Apr 10 2024, 23:04

tobias_ruck added a parent revision: D15938: [ecash-lib] Add `Op`, opcode consts, readOp, writeOp.

re-run CI

modules/ecash-lib/src/op.ts
99 ↗	(On Diff #47011)	mb `getMinPushBytesOp`, `pushBytesOpScript`, or something more specific? we will need similar-ish function(s) for different specific use cases like SLP

This revision now requires changes to proceed.Apr 11 2024, 03:55

fix pushBytesOp case where data starts with eg. 16 but isn't size 1

Harbormaster completed remote builds in B28494: Diff 47055.Apr 11 2024, 22:31

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-tests) failed.

Tail of the build log:

Test does not depend on mock-chronik-client, skipping mock-chronik-client dependencies...
Test depends on ecash-lib-wasm. Building WebAssembly...
/work/modules/ecash-lib-wasm /work/abc-ci-builds/ecash-lib-tests
./build-wasm.sh: line 5: cargo: command not found
Failed opening './target/wasm32-unknown-unknown/release-wasm/ecash_lib_wasm.wasm'
./build-wasm.sh: line 19: wasm-bindgen: command not found
Build ecash-lib-tests failed with exit code 127

tobias_ruck added inline comments.Apr 11 2024, 22:32

modules/ecash-lib/src/op.ts
99 ↗	(On Diff #47011)	This function will be used a lot in covenants, so keeping it small and concise makes the most sense. Also, it's kind of the default, and SLP really is the exception, so IMO the naming makes sense. If the SLP deviation didn't exist I wouldn't even add this function and just have `type Op = number \| Uint8Array` and always encode minimally, but this way we kinda keep the conciseness without the lack of explicitness.