Page MenuHomePhabricator

[Cashtab] After a token is created, automatically navigate to its actions screen
ClosedPublic

Authored by bytesofman on Thu, Apr 11, 23:51.

Details

Summary

T3528

The way Cashtab works right now, after you create a token, you must find it from the mystery list. Also you must know where the mystery list of tokens is (you click the mystery token icon, duh). Also it is of course not in alphabetical order.

The mystery list will be improved separately. Regardless, it makes sense for the user to be forwarded to the token they just created.

Note: we have a race condition in that Cashtab will update the wallet and navigate to the token page before the token server has resized its icon. I do not think it is wise to add a setTimeout to (maybe) handle this. We can optmize this later if people are confused.

Test Plan

npm test, can try live at https://cashtab-local-dev.netlify.app/ where a version with console.log statements is up (and the token server will take icons from this url)

image.png (559×705 px, 92 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman edited the test plan for this revision. (Show Details)
bytesofman edited the summary of this revision. (Show Details)
emack requested changes to this revision.Fri, Apr 12, 01:00
emack added a subscriber: emack.

It's not routing for me as the createdTokenId is always coming up as null in the console logs.

And on an unrelated note, perhaps minting/burning txs should display the txFee as the sent amount rather than the output? Otherwise it looks like the user spent the change amount (as the case here) as part of the tx fee.

image.png (236×514 px, 24 KB)

This revision now requires changes to proceed.Fri, Apr 12, 01:00

improve logic so it happens if a token id is not submitted to the server, add a test

This revision is now accepted and ready to land.Fri, Apr 12, 04:25