[Cashtab] After a token is created, automatically navigate to its actions screen
ClosedPublic
Actions

Authored by bytesofman on Apr 11 2024, 23:51.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC618b435026d9: [Cashtab] After a token is created, automatically navigate to its actions screen

Summary

T3528

The way Cashtab works right now, after you create a token, you must find it from the mystery list. Also you must know where the mystery list of tokens is (you click the mystery token icon, duh). Also it is of course not in alphabetical order.

The mystery list will be improved separately. Regardless, it makes sense for the user to be forwarded to the token they just created.

Note: we have a race condition in that Cashtab will update the wallet and navigate to the token page before the token server has resized its icon. I do not think it is wise to add a setTimeout to (maybe) handle this. We can optmize this later if people are confused.

Test Plan

npm test, can try live at https://cashtab-local-dev.netlify.app/ where a version with console.log statements is up (and the token server will take icons from this url)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nav-to-token-page-after-create

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28507
Build 56555: Build Diff	cashtab-tests
Build 56554: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 11 2024, 23:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2024, 23:51

bytesofman edited the summary of this revision. (Show Details)Apr 11 2024, 23:53

bytesofman edited the test plan for this revision. (Show Details)

bytesofman edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B28503: Diff 47066.Apr 11 2024, 23:55

bytesofman published this revision for review.Apr 11 2024, 23:59

It's not routing for me as the createdTokenId is always coming up as null in the console logs.

And on an unrelated note, perhaps minting/burning txs should display the txFee as the sent amount rather than the output? Otherwise it looks like the user spent the change amount (as the case here) as part of the tx fee.